Skip to content

Skip ccpages #218

Merged
yi-xmu merged 1 commit intoeloq-10.6.10from
skip_ccpages
Jan 22, 2026
Merged

Skip ccpages #218
yi-xmu merged 1 commit intoeloq-10.6.10from
skip_ccpages

Conversation

@yi-xmu
Copy link
Collaborator

@yi-xmu yi-xmu commented Jan 20, 2026 •
edited by coderabbitai bot
Loading

Enable test case.

Summary by CodeRabbit

  • Tests
    • Removed a conditional skip from a test to ensure consistent test execution across all configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

@yi-xmu yi-xmu self-assigned this Jan 20, 2026
@yi-xmu yi-xmu mentioned this pull request Jan 20, 2026
Merged
5 tasks
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026 •
edited
Loading

Walkthrough

A conditional skip block is removed from a fault index test, allowing the test to always execute regardless of Cassandra storage configuration, rather than being bypassed when eloq_kv_storage is set to cass.

Changes

Cohort / File(s) Summary
Test Configuration
storage/eloq/mysql-test/mono_multi/t/fault_create_drop_index.test		 Removed conditional skip that previously bypassed test when Cassandra storage was enabled; test now runs unconditionally

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A skip block removed, the test runs free,
No more Cassandra holding back the key,
Forward it marches through fault and through drop,
Indexing fearless, it will not stop! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Skip ccpages' is vague and generic, using non-descriptive terminology that doesn't clearly convey what change was made to the test file or why the conditional skip was removed. Revise the title to be more specific and descriptive, such as 'Remove Cassandra conditional skip from fault_create_drop_index test' or 'Enable fault_create_drop_index test for all storage backends'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch skip_ccpages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yi-xmu yi-xmu merged commit ab9e57c into eloq-10.6.10 Jan 22, 2026
4 checks passed
@yi-xmu yi-xmu deleted the skip_ccpages branch February 3, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiexiaoy xiexiaoy xiexiaoy approved these changes

Assignees

@yi-xmu yi-xmu

Labels

trigger-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yi-xmu @xiexiaoy